Conversation
We hand radio stations to HA as the music class because HA has none for radio, and that same class was read back as radio when searching. A voice assistant picks music for any plain play request, so those searched radio only and silently found nothing.
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: music_assistant
small-pr
Contributor
|
Hey there @music-assistant, @arturpragacz, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
zweckj
approved these changes
Jul 31, 2026
Comment on lines
+91
to
+93
| # music is the class a voice assistant picks for a plain "play something" | ||
| # request, so it has to mean music rather than the radio stations we | ||
| # happen to hand back to HA under the same class |
Member
There was a problem hiding this comment.
Suggested change
| # music is the class a voice assistant picks for a plain "play something" | |
| # request, so it has to mean music rather than the radio stations we | |
| # happen to hand back to HA under the same class |
This comment isn't true.
Our own Assist for example never does it. Maybe some overzealous LLMs incorrectly add it?
Also as a sidenote: we could consider mapping radio channels to MediaClass.CHANNEL instead.
Comment on lines
+575
to
+578
|
|
||
| A voice assistant sends this class for a plain "play something" request, | ||
| and we hand radio stations back to HA under the same class, which is why | ||
| it used to end up searching radio only. |
Member
There was a problem hiding this comment.
Suggested change
| A voice assistant sends this class for a plain "play something" request, | |
| and we hand radio stations back to HA under the same class, which is why | |
| it used to end up searching radio only. |
Same as above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Asking a voice assistant to "play some music" or "play songs by " did nothing on Music Assistant, while the assistant still said it was playing.
HA has no media class for radio, so we hand radio stations back under the music class. That same class was then read back as radio when searching, and a voice assistant picks music for any plain play request, so those searches only ever looked at radio stations and came back empty.
Music now means music, and radio keeps the class it is shown with.
Stacked on #177673, which touches the same mapping. Only the last commit belongs to this one.
Type of change
Additional information
media_class: musicplays nothing - Music Assistant mapsMediaClass.MUSICtoRADIO#173602Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: