feat: force account picker when adding a Spotify account - #177669
Open
felixschndr wants to merge 2 commits into
Open
feat: force account picker when adding a Spotify account#177669felixschndr wants to merge 2 commits into
felixschndr wants to merge 2 commits into
Conversation
Contributor
|
Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Send show_dialog=true on the authorize URL so Spotify shows the approval screen and the user can pick a different account. Fixes home-assistant#177665
Fixes "2026-07-30 17:22:53.999 WARNING (MainThread) [homeassistant.helpers.frame] Detected that integration 'spotify' creates a config entry when another entry with the same unique ID exists. This will stop working in Home Assistant 2026.3, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+spotify%22 "
felixschndr
force-pushed
the
spotify-fix-multi-account
branch
from
July 30, 2026 17:27
0f9d62b to
169c7f6
Compare
felixschndr
marked this pull request as ready for review
July 30, 2026 17:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Send show_dialog=true on the authorize URL so Spotify shows the approval screen and the user can pick a different account.
Also abort account creation flow when account is already setup. This lead to the log message
2026-07-30 17:22:53.999 WARNING (MainThread) [homeassistant.helpers.frame] Detected that integration 'spotify' creates a config entry when another entry with the same unique ID exists. This will stop working in Home Assistant 2026.3, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+spotify%22.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: