Skip to content

feat: force account picker when adding a Spotify account - #177669

Open
felixschndr wants to merge 2 commits into
home-assistant:devfrom
felixschndr:spotify-fix-multi-account
Open

feat: force account picker when adding a Spotify account#177669
felixschndr wants to merge 2 commits into
home-assistant:devfrom
felixschndr:spotify-fix-multi-account

Conversation

@felixschndr

@felixschndr felixschndr commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Send show_dialog=true on the authorize URL so Spotify shows the approval screen and the user can pick a different account.

Also abort account creation flow when account is already setup. This lead to the log message 2026-07-30 17:22:53.999 WARNING (MainThread) [homeassistant.helpers.frame] Detected that integration 'spotify' creates a config entry when another entry with the same unique ID exists. This will stop working in Home Assistant 2026.3, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+spotify%22.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings July 30, 2026 17:14
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: spotify small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage labels Jul 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @frenck, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (spotify) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of spotify can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign spotify Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Send show_dialog=true on the authorize URL so Spotify shows the approval screen and the user can pick a different account.

Fixes home-assistant#177665
Fixes "2026-07-30 17:22:53.999 WARNING (MainThread) [homeassistant.helpers.frame] Detected that integration 'spotify' creates a config entry when another entry with the same unique ID exists. This will stop working in Home Assistant 2026.3, please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+spotify%22
"
@felixschndr
felixschndr force-pushed the spotify-fix-multi-account branch from 0f9d62b to 169c7f6 Compare July 30, 2026 17:27
@felixschndr
felixschndr marked this pull request as ready for review July 30, 2026 17:29
Copilot AI review requested due to automatic review settings July 30, 2026 17:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed has-tests integration: spotify Quality Scale: No score small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spotify does not find linked accounts

4 participants