Fix: Silently ignore empty JSON string object for MQTT IR signal payload - #177664
Open
jbouwh wants to merge 1 commit into
Open
Fix: Silently ignore empty JSON string object for MQTT IR signal payload#177664jbouwh wants to merge 1 commit into
jbouwh wants to merge 1 commit into
Conversation
Contributor
|
Hey there @emontnemery, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Silently ignores empty JSON-string MQTT infrared payloads instead of logging warnings.
Changes:
- Treats
""as an ignorable payload. - Adds regression coverage for debug logging and signal suppression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/mqtt/infrared.py |
Ignores empty JSON-string payloads. |
tests/components/mqtt/test_infrared.py |
Tests the new behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix: Silently ignore empty JSON string object for MQTT IR signal payload. When the infrared MQTT entity receives timings, these are often extracted using a valuetemplate. While a dict is expected we should ignore an empty JSON string
"".This fix wil no longer log warnings when the value is an empty string, like:
Invalid message received for infrared.irhub_learned_ir_timings on topic zigbee2mqtt/irhub, with template Template<template=({{ value_json.learned_ir_timings | tojson }}) renders=1>. Message is not a valid signal JSON message. Got
{"ir_code_to_send":null,"ir_emitter":null,"learn_ir_code":null,"learned_ir_code":"Some code...","learned_ir_timings":"","linkquality":120}Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: