Skip to content

Update Google Health sensor units to be more reasonable - #177657

Open
allenporter wants to merge 1 commit into
home-assistant:devfrom
allenporter:google-health-weight-unit
Open

Update Google Health sensor units to be more reasonable#177657
allenporter wants to merge 1 commit into
home-assistant:devfrom
allenporter:google-health-weight-unit

Conversation

@allenporter

@allenporter allenporter commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Add dynamic unit suggestion logic for Google Health sensors via a new suggested_unit_fn callback on GoogleHealthSensorEntityDescription.

By default, Home Assistant does not convert weights/masses across unit systems automatically (to prevent body scales from defaulting to grams), and generic unit system mappings for distance and volume convert to architectural/utility defaults (m -> ft, L -> gal).

This PR configures unit-system-aware defaults tailored for a fitness/health tracker:

  • Weight sensor: Defaults to pounds (lb) for US Customary users and kilograms (kg) for Metric users.
  • Distance sensor: Defaults to miles (mi) for US Customary users and kilometers (km) for Metric users (instead of feet or raw meters).
  • Hydration / Water intake sensor: Defaults to fluid ounces (fl. oz.) for US Customary users (instead of gallons).
  • Parameterized unit testing: Added test_sensor_unit_conversions with pytest.approx() to test unit system conversions across METRIC_SYSTEM and US_CUSTOMARY_SYSTEM.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@allenporter
allenporter force-pushed the google-health-weight-unit branch from 72eaf2d to ff881cb Compare July 30, 2026 15:26
@allenporter allenporter changed the title Google Health: Add dynamic unit suggestion for weight sensor Update Google Health sensor units to be more reasonable Jul 30, 2026
@allenporter
allenporter marked this pull request as ready for review July 30, 2026 15:30
@allenporter
allenporter requested a review from joostlek July 30, 2026 15:30
@allenporter allenporter added this to the 2026.8.0 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant