Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: bluetooth
small-pr
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Clears stale restored Bluetooth entity names so translated names apply after restart.
Changes:
- Clears stored names for keys updated without names.
- Adds tests for clearing, repeat updates, and partial naming.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/bluetooth/passive_update_processor.py |
Adds stale-name clearing logic. |
tests/components/bluetooth/test_passive_update_processor.py |
Tests name update behavior. |
Comment on lines
+172
to
+175
| if not new_data.entity_names: | ||
| for key in ( | ||
| new_data.entity_data.keys() | new_data.entity_descriptions.keys() | ||
| ): |
Member
Author
|
Closing in favor of sending explicit None entries from the integration, see #177644. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Integrations that migrated to translated entity names pass
entity_names={}(BTHome #156060, OralB #97402, Bluemaestro #102424). However, names persisted before the migration are restored from storage at startup, andPassiveBluetoothDataUpdate.update()only merges incoming mappings, so those entities keep the old hardcoded English names forever on existing installations.Clear the stored name for updated keys when an update provides no names at all, which is the signature of the
entity_names={}pattern. Updates that name some entities keep the current merge behavior, so partial updates (multi-packet devices) and integrations that rely on previously sent names are unaffected. The cleared names are persisted, and entities pick up the translated names on the next restart.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: