Make config entry field required in DuckDNS set_txt action - #177614
Open
tr4nt0r wants to merge 1 commit into
Open
Make config entry field required in DuckDNS set_txt action#177614tr4nt0r wants to merge 1 commit into
set_txt action#177614tr4nt0r wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Finalizes the DuckDNS set_txt action deprecation by requiring a config entry.
Changes:
- Makes
config_entry_idmandatory. - Removes legacy fallback and repair-issue handling.
- Updates tests and quality-scale metadata.
Quality-scale verification found no rule issues.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/duckdns/services.py |
Enforces config-entry selection. |
homeassistant/components/duckdns/services.yaml |
Marks the field required. |
homeassistant/components/duckdns/issue.py |
Removes obsolete deprecation issue. |
homeassistant/components/duckdns/quality_scale.yaml |
Exempts the repairs rule. |
tests/components/duckdns/test_init.py |
Updates service tests for required entries. |
tr4nt0r
force-pushed
the
duckdns_config_entry_required
branch
from
July 30, 2026 03:21
22ffe79 to
090a8df
Compare
tr4nt0r
marked this pull request as draft
July 30, 2026 03:22
tr4nt0r
force-pushed
the
duckdns_config_entry_required
branch
from
July 30, 2026 03:24
090a8df to
6a85712
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tests/components/duckdns/test_init.py:168
- Add a regression test that omits
config_entry_idand asserts schema validation fails. The previous missing-entry case was deleted, so the required-field behavior introduced by this PR is not exercised by the remaining tests.
async def test_service_config_entry_not_found(
homeassistant/components/duckdns/services.py:18
- Fill in the PR's
## Proposed changesection. It is currently empty, so the description does not satisfy the required PR template for this breaking schema change.
vol.Required(ATTR_CONFIG_ENTRY): ConfigEntrySelector({"integration": DOMAIN}),
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tests/components/duckdns/test_init.py:168
- Keep a test that calls
set_txtwithoutconfig_entry_idand asserts schema validation fails. Replacing the previous missing-entry case removes direct coverage of the required-field behavior that this PR introduces, so the service could become optional again without these tests detecting it.
@pytest.mark.usefixtures("setup_duckdns")
async def test_service_config_entry_not_found(
homeassistant/components/duckdns/services.py:18
- Complete the PR's
## Proposed changesection with the reason for making config entry selection mandatory. That section is currently empty, so the description does not provide the required rationale for this breaking action change.
vol.Required(ATTR_CONFIG_ENTRY): ConfigEntrySelector({"integration": DOMAIN}),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Calling the
duckdns.set_txtaction without a config entry has been deprecated and is now a required field.Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: