Add interpolation and WebP radar options to Environment Canada - #177572
Open
michaeldavie wants to merge 3 commits into
Open
Add interpolation and WebP radar options to Environment Canada#177572michaeldavie wants to merge 3 commits into
michaeldavie wants to merge 3 commits into
Conversation
Contributor
|
Hey there @gwww, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in smoothing and WebP output options to Environment Canada radar cameras.
Changes:
- Adds interpolation and WebP options with backward-compatible defaults.
- Passes saved options to
ECMapand expands tests. - Updates translations and
env-canadato 0.18.0.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/environment_canada/__init__.py |
Passes new options to ECMap. |
homeassistant/components/environment_canada/config_flow.py |
Adds both options to the options flow. |
homeassistant/components/environment_canada/const.py |
Defines option keys and defaults. |
homeassistant/components/environment_canada/manifest.json |
Updates the dependency version. |
homeassistant/components/environment_canada/strings.json |
Adds user-facing option text. |
requirements_all.txt |
Updates the generated dependency requirement. |
tests/components/environment_canada/test_config_flow.py |
Tests option persistence and ECMap arguments. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds two options to the Environment Canada radar camera's options flow (introduced in #173415):
radar_interpolation, boolean): requests theINTERPOLATION=TRUEWMS parameter from Environment Canada so the rendered radar layer is smoothed instead of pixelated. Defaults toFalse, the previous hardcoded behaviour.radar_webp, boolean): requests the radar layer as WebP instead of PNG and returns camera/animation output as WebP instead of PNG/GIF, trading higher per-frame latency for lower bandwidth. Defaults toFalse, the previous hardcoded behaviour.Defaults to the previous behaviour, so existing installations are unchanged until the user opts in.
This depends on the
env-canada0.18.0 bump in #177569 (adds theECMapinterpolation/webpparameters), and is stacked on that branch — please merge #177569 first.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: