Bug fixes: spacing relaunch, hotkeys, XPC on ad hoc builds, permission wait, data race, allowlist

[holzcloud]

Phase 2, the bug fixes, is complete: this pull request fixes BUG-01 to BUG-08 (spacing relaunch, hotkeys, XPC on ad hoc builds, permission wait, data race, allowlist) and removes the app's former name from the repository. It stays a draft until it is marked ready.

• BUG-01 Applying menu bar item spacing relaunches every app with a menu bar item: a skipped process (Control Center or holzBar itself) no longer ends the loop. The logic lives in the new pure holzBar/Core folder (HolzBarCore, SpacingRelaunch suite).
• BUG-02 An app gets 10 seconds to quit and is never force terminated; one that is still running is left alone and named in the alert. The wait observes isTerminated instead of polling and always returns, at the event, the timeout or cancellation.
• BUG-03 On macOS 27 the owners of the items come from the Accessibility read, and MenuBarAgent is never quit.
• BUG-04 The event source cache in MenuBarItemManager.getEventSource(with:) is read and filled only inside one OSAllocatedUnfairLock (withLockUnchecked, as CGEventSource is not Sendable), so concurrent item moves and clicks can no longer corrupt it.
• BUG-05 On macOS 15 and later the hotkey recorder refuses a combination whose only modifiers are Option, or Option and Shift, and explains that Command or Control is needed (Modifiers suite).
• BUG-06 The macOS 26 menu bar item service accepts holzBar's own ad hoc builds, which have no team identifier, and still rejects every other process: it requires holzBar's signing identifier and one of the code directory hashes of the app it is embedded in (same team plus identifier on a team-signed build), and does not listen at all when it cannot build that requirement. Shared/CodeSigning/CodeSignature.swift reads the hashes with Security only, so the app still launches on macOS 14.0 (CodeSignature suite).
• BUG-07 Permission.waitForPermission() returns a Bool and any number of waits end, so the permissions window comes to the front once when a permission is granted and does not reopen by itself.
• BUG-08 The macOS 27 system item allowlist is 0 through 127, the range MenuBarAgent was measured to accept (one at a time and all at once), instead of 0 through 63. It lives in the new Core file SystemItems27.swift (SystemItems27 suite), the assertion builds its configuration from it, and its comment says what the code does: macOS 27 support: remaining gaps on top of #995 jordanbaird/Ice#1001 keeps 0 to 63, which lies inside it.
• Cleanup The app's former name is gone from the repository. The cask points only at holzBar (no rename mapping), the app imports settings only from Ice and accepts only holzbar://, an unknown stored icon decodes as the default, past release notes say holzBar, and a former-name job in build.yml keeps the name out.

Verified by: the CI build (BUILD SUCCEEDED, no warning in the changed files), swift test (140 tests in 26 suites, including the new SpacingRelaunch, Modifiers, CodeSignature and SystemItems27 suites of the HolzBarCore, SharedCodeSigning and HolzBarMacOS27Core targets), and strict SwiftLint (0 violations).

Still to check by hand on a Mac:

• macOS 26.7.1: with several apps that have menu bar items running, change "Menu bar item spacing" and press Apply. Every app with a menu bar item quits and reopens, including when Control Center or holzBar would have come first. Repeat once: the same set relaunches.
• macOS 26.7.1: run an app that asks before quitting (leave the question unanswered) and apply spacing. The app is not killed; after about 10 s holzBar shows "did not quit within 10 seconds and were not restarted" naming it; the other apps relaunch.
• macOS 27: apply spacing. No alert names MenuBarAgent, and the apps with menu bar items relaunch. Note whether the spacing between items changes; if it does not, MenuBarAgent reads the setting itself and a follow-up is needed.
• macOS 26.7.1, Settings, Hotkeys: Option-H shows "macOS does not allow this hotkey" saying Command or Control is needed, and after OK the recorder still records; Option-Shift-H shows the same alert; Command-Option-H records and fires from another app. Hotkeys set before the update still work.
• Permissions window with Screen Recording reset (tccutil reset ScreenCapture com.holzcloud.holzBar): "Grant Permission", then "Reset and Grant Again", then grant in System Settings: the window comes to the front once and shows it as granted. Reset again, "Grant Permission", do not grant, click Continue: the window does not reopen by itself later.
• macOS 26.7.1 with an ad hoc build (CI or Scripts/install.sh): with log stream --level info --predicate 'process == "MenuBarItemService" OR subsystem BEGINSWITH "com.holzcloud.holzBar"' running, launch holzBar and open Settings, Menu Bar Layout. The service logs "Listener requires the app's exact code (N code directory hashes)" with N ≥ 1, the layout shows the menu bar items instead of "Loading menu bar items…", and no "looking up source processes in the app instead" line appears.
• macOS 26.7.1, Settings, Menu Bar Layout: drag several items between sections in quick succession, and click hidden items in the holzBar Shelf while a move is still running. Items move and open as before; holzBar does not crash.
• macOS 27: hide a few apps' items with holzBar. Battery, clock, Wi-Fi and Control Centre stay on the bar while the hidden apps' items disappear, as before.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BSzFQk1ZzGXFVBDZMYq8eu

---

Generated by Claude Code