The "toggled open" handler can now fire on both "open" and "close" events#2626
Open
v-ein wants to merge 2 commits intohoffstadt:masterfrom
Open
The "toggled open" handler can now fire on both "open" and "close" events#2626v-ein wants to merge 2 commits intohoffstadt:masterfrom
v-ein wants to merge 2 commits intohoffstadt:masterfrom
Conversation
…r changes, no API rebuild in this fix.
…nts. This helps circumvent the change introduced in hoffstadt#1280 and handle the close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: The "toggled open" handler can now fire on both "open" and "close" events
assignees: @hoffstadt
Description:
This PR adds an option to
add_item_toggled_open_handlerto make the handler fire when the "open" state is toggled both from closed to open and vice versa, like it is in Dear ImGui. This allows the application to catch it when the user collapses a tree node or a collapsing header, and handle it as needed.The new option effectively provides an opt-out from #1280.
This PR also fixes some typos in the codebase that I didn't want to put into a separate PR. None of them change DPG behavior.
Concerning Areas:
None.