Skip to content

feat: flagging what is externally managed and what isn't#166

Merged
oliveregger merged 5 commits into
hl7ch:masterfrom
trifork:feature/governance-flagging
May 19, 2026
Merged

feat: flagging what is externally managed and what isn't#166
oliveregger merged 5 commits into
hl7ch:masterfrom
trifork:feature/governance-flagging

Conversation

@jkiddo
Copy link
Copy Markdown
Contributor

@jkiddo jkiddo commented May 6, 2026

This pull request updates how code systems and value sets are listed in the implementation guide by replacing simple include statements with custom logic that categorizes resources based on their source. The new approach clearly separates resources managed in ART-DECOR from those managed in the implementation guide itself, and provides direct links for each resource.

Resource listing improvements:

  • Replaced the {% include list-simple-codesystems.xhtml %} in codesystems.md with a custom section in codesystems.xml that generates two categorized lists: one for code systems managed in ART-DECOR and one for those managed in the implementation guide. Each entry links to the resource and is generated dynamically from site.data.resources. [1] [2]
  • Replaced the {% include list-simple-valuesets.xhtml %} in valuesets.md with a similar custom section in valuesets.xml that categorizes value sets by their source and generates dynamic lists with links. [1] [2]

@ralych ralych self-requested a review May 7, 2026 10:50
@oliveregger oliveregger self-requested a review May 18, 2026 19:37
Copy link
Copy Markdown
Collaborator

@oliveregger oliveregger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the pr!

@oliveregger oliveregger linked an issue May 18, 2026 that may be closed by this pull request
@oliveregger
Copy link
Copy Markdown
Collaborator

patch.diff.zip

@oliveregger
Copy link
Copy Markdown
Collaborator

added a patch to update the changelog

ralych
ralych previously approved these changes May 18, 2026
Comment thread input/pagecontent/valuesets.md
Comment thread input/pagecontent/codesystems.md
@ralych ralych self-requested a review May 18, 2026 20:33
@ralych ralych dismissed their stale review May 18, 2026 20:39

Erroreoneus approval

@jkiddo
Copy link
Copy Markdown
Contributor Author

jkiddo commented May 18, 2026

@ralych fixed

Comment thread input/pagecontent/valuesets.md Outdated
Comment thread input/pagecontent/codesystems.md Outdated
@oliveregger
Copy link
Copy Markdown
Collaborator

@jkiddo i tried to do that with a cross pr (changelog and remove div): https://github.com/trifork/ch-term/pull/1/changes

Add changelog entry and clean up page wrappers for hl7ch#170
@jkiddo
Copy link
Copy Markdown
Contributor Author

jkiddo commented May 19, 2026

@oliveregger thx! Merged.

Copy link
Copy Markdown
Collaborator

@ralych ralych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are ok

@oliveregger oliveregger merged commit 7893a76 into hl7ch:master May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flagging what is managed in art-decor and what isn't

3 participants