Feature: Automated Testing & CI/CD Pipeline#53
Conversation
✅ Deploy Preview for smartrentsystem ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@hitesh-kumar123 could you pls verify and merge it |
|
Thanks for the detailed PR — the testing & CI setup is a solid improvement 👍 Before merging, a few blocking issues need to be addressed: server.js has a duplicate require("./app") — please keep only the exported app import. MongoDB connection logic was changed; please ensure safe fallback handling when env vars are missing. Please re-check backend/package.json — the current diff suggests duplicate keys / missing commas. Clarify whether /api/properties/test is a test-only endpoint or production route. Large lockfile changes (frontend + backend) make review difficult — consider isolating them if possible. Once these are fixed, I’ll be happy to approve and merge. |
|
@hitesh-kumar123 Sorry for the trouble! i have made the necessary changes, i hope it is fine now. |
promiseer
left a comment
There was a problem hiding this comment.
@Shravanthi20 check comments and push your changes
|
@hitesh-kumar123 @promiseer could you pls check, if the PR can be merged. |
PR: Feat: Automated Testing & CI/CD Pipeline
📌 Linked Issue
🛠 Changes Made
jestandsupertestfor backend API testing.testscript.🧪 Testing
npm test)npm testlocally inbackend/directory -> All passed.📸 UI Changes (if applicable)
(Backend changes only)
📝 Documentation Updates
✅ Checklist
💡 Additional Notes (If any)