Add underline styling to footer headings for consistency#155
Add underline styling to footer headings for consistency#155nikhil-2040 wants to merge 1 commit into
Conversation
✅ Deploy Preview for smartrentsystem ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
add issue number |
|
add image before after |
| </a> | ||
| </div> | ||
| </div> | ||
| {/* Company Info */} |
There was a problem hiding this comment.
Duplicate comment detected. One of the {/* Company Info */} comments can be safely removed to avoid redundancy and improve readability.
| @@ -61,55 +61,62 @@ const Footer = () => { | |||
| aria-label="Footer navigation" | |||
There was a problem hiding this comment.
Consider wrapping this section inside a semantic
element instead of only using aria-label. This improves accessibility and screen-reader navigation.| href="https://facebook.com" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="bg-neutral-800/80 hover:bg-primary-600 text-white h-9 w-9 sm:h-10 sm:w-10 rounded-full |
There was a problem hiding this comment.
For consistency and maintainability, consider extracting a shared class or reusable component for social icons.
| hover:rotate-[360deg]" | ||
| aria-label="Follow us on Facebook" | ||
| > | ||
| <i className="fab fa-facebook-f"></i> |
There was a problem hiding this comment.
Icons inside anchor tags should include aria-hidden="true" or be wrapped with visually hidden text to improve screen-reader accessibility.
|
|
||
| <li> | ||
| <Link | ||
| to="/faq" |
There was a problem hiding this comment.
Route paths are hardcoded in multiple places. Defining route constants can improve scalability and reduce the risk of future routing inconsistencies.
3 participants
📌 Linked Issue
🛠 Changes Made
🧪 Testing
npm test)📸 UI Changes (if applicable)
📝 Documentation Updates
✅ Checklist
💡 Additional Notes
This change focuses on improving UI consistency without affecting existing functionality.