Skip to content

feat: add Trips/Bookings shortcut to navbar#108

Open
SRUTHIAGARWAL wants to merge 1 commit into
hitesh-kumar123:mainfrom
SRUTHIAGARWAL:feature/navbar-bookings-icon
Open

feat: add Trips/Bookings shortcut to navbar#108
SRUTHIAGARWAL wants to merge 1 commit into
hitesh-kumar123:mainfrom
SRUTHIAGARWAL:feature/navbar-bookings-icon

Conversation

@SRUTHIAGARWAL

Copy link
Copy Markdown

name: "📦 Pull Request"
about: Submit changes for review
title: "PR: Adding an icon which will redirect the logged users to the bookings page where the users booked places are present"

📌 Linked Issue


🛠 Changes Made

  • Added: A booking icon to the navbar only for the logged in users
  • Fixed: Direct navigation to bookings page via the booking icon
  • Updated: Navbar UI to quick access to the bookings just like other platforms of bookings

Testing

  • [✅ ] Ran unit tests (npm test)
  • [✅ ] Tested manually (describe below):
  • In the local development environment start both backend and frontend
  • Now login as a user and observe the navbar you can observe a suitcase icon by clicking on it you will be redirected to the bookings page.

📸 UI Changes (if applicable)

| Before |
image

After |
image


📝 Documentation Updates

  • Updated README/docs
  • [ ✅] Added code comments

✅ Checklist

  • [ ✅] Created a new branch for PR
  • [ ✅] Have stared the repository
  • [ ✅] Follows JavaScript Styleguide
  • [ ✅] No console warnings/errors
  • [ ✅] Commit messages follow Git Guidelines

💡 Additional Notes (If any)

  • This PR focuses only on Navbar-level UI changes.
  • Designed to coexist cleanly with other Navbar-related PRs (e.g., Wishlist icon).

@netlify

netlify Bot commented Jan 11, 2026

Copy link
Copy Markdown

Deploy Preview for smartrentsystem ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8ae1348
🔍 Latest deploy log https://app.netlify.com/projects/smartrentsystem/deploys/6963d4f023bc370008e236f3
😎 Deploy Preview https://deploy-preview-108--smartrentsystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SRUTHIAGARWAL

Copy link
Copy Markdown
Author

Hi @hitesh-kumar123 ,
The feature was working as expected on my end.
Could you please let me know what needs to be changed for this PR to be accepted?
I’d be happy to update it accordingly. Thanks!

@hitesh-kumar123

Copy link
Copy Markdown
Owner

❌ PR Closed

Thanks for the contribution.

This PR was closed because it breaks the navbar layout and responsiveness.
The icon changes disrupted the existing navbar flow, and no responsive testing or before/after screenshots were provided.

Major UI components like the navbar should not be changed without prior discussion.

You’re welcome to open a new PR with minimal, issue-focused changes and proper testing.

Screenshot 2026-01-13 230635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants