Skip to content

feat: add messages icon to navbar#107

Open
SRUTHIAGARWAL wants to merge 1 commit into
hitesh-kumar123:mainfrom
SRUTHIAGARWAL:feature/navbar-messages-icon
Open

feat: add messages icon to navbar#107
SRUTHIAGARWAL wants to merge 1 commit into
hitesh-kumar123:mainfrom
SRUTHIAGARWAL:feature/navbar-messages-icon

Conversation

@SRUTHIAGARWAL

Copy link
Copy Markdown

name: "📦 Pull Request"
about: Submit changes for review
title: "PR: Adding messages icon to navbar so that user can easily be redirected to the messages page"

📌 Linked Issue


🛠 Changes Made

  • Added: Messages icon to the Navbar for authenticated users
  • Added: Direct navigation to the /messages page via the Navbar icon
  • Updated: Navbar UI to include quick-access messaging similar to common rental platforms

🧪 Testing

-✅ Ran unit tests (npm test)
-✅ Tested manually (describe below):

  • Test case 1:
  • First open the project locally in development environment.
  • Start the backend and frontend
  • Now observe the navbar no message icon is displayed
  • when you login or sign up you can see the message icon and when you click it then it redirects to the messages page

📸 UI Changes

| Before |
image

|After |
image


📝 Documentation Updates

  • Updated README/docs
  • ✅ Added code comments

✅ Checklist

-✅ Created a new branch for PR
-✅ Have stared the repository
-✅ Follows JavaScript Styleguide
-✅ No console warnings/errors
-✅ Commit messages follow Git Guidelines

💡 Additional Notes

  • This PR focuses only on Navbar-level UI changes.
  • Designed to coexist cleanly with other Navbar-related PRs (e.g., Wishlist icon).

@netlify

netlify Bot commented Jan 11, 2026

Copy link
Copy Markdown

Deploy Preview for smartrentsystem ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 39199db
🔍 Latest deploy log https://app.netlify.com/projects/smartrentsystem/deploys/6963b5d8b2815300089298b3
😎 Deploy Preview https://deploy-preview-107--smartrentsystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SRUTHIAGARWAL

Copy link
Copy Markdown
Author

@hitesh-kumar123 can you please tell me what was the issue?

@hitesh-kumar123

Copy link
Copy Markdown
Owner
image

❌ PR Closed

Thanks for the contribution.

This PR was closed because it breaks the navbar layout and responsiveness.
The icon changes disrupted the existing navbar flow, and no responsive testing or before/after screenshots were provided.

Major UI components like the navbar should not be changed without prior discussion.

You’re welcome to open a new PR with minimal, issue-focused changes and proper testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants