Skip to content

feat: add wishlist icon highlight in navbar#105

Open
SRUTHIAGARWAL wants to merge 1 commit into
hitesh-kumar123:mainfrom
SRUTHIAGARWAL:feature/navbar-wishlist-highlight
Open

feat: add wishlist icon highlight in navbar#105
SRUTHIAGARWAL wants to merge 1 commit into
hitesh-kumar123:mainfrom
SRUTHIAGARWAL:feature/navbar-wishlist-highlight

Conversation

@SRUTHIAGARWAL

Copy link
Copy Markdown

Linked Issue

*Connected to: #96
(Wishlist icon visibility & active highlight in navbar)


🛠 Changes Made

  • Added: Wishlist (heart) icon in the navbar for quick access to saved listings.
  • Added: Active state highlighting for the wishlist icon when the user is on the /wishlist page.
  • Improved: Navbar navigation consistency by making wishlist access more discoverable and intuitive.
  • Maintained: Existing wishlist functionality without altering backend or API behavior.

🧪 Testing

Manual Testing Performed:

  • Test case 1:

    • Steps: Log in → Observe navbar
    • Expected Result: Wishlist icon is visible in the navbar.
  • Test case 2:

    • Steps: Click wishlist icon → Navigate to /wishlist
    • Expected Result: Wishlist page opens and navbar wishlist icon is highlighted.
  • Test case 3:

    • Steps: Navigate to other pages
    • Expected Result: Wishlist icon is visible but not highlighted.

No automated tests were added as this change is UI-focused.


📸 UI Changes

| Before
image

| Wishlist accessible only via profile menu |
| After |
image

Wishlist icon visible directly in navbar with active highlight |


📝 Documentation Updates

  • No documentation updates required for this UI-only enhancement.

✅ Checklist

  • Created a dedicated feature branch for this PR - yes
  • Repository is starred - yes
  • Code follows the project’s JavaScript style guide - yes
  • No console errors introduced - yes
  • Commit messages follow repository guidelines - yes

💡 Additional Notes

  • This change improves UX by reducing clicks needed to access the wishlist.
  • No breaking changes introduced.
  • Backend APIs and existing wishlist logic remain untouched.

@netlify

netlify Bot commented Jan 11, 2026

Copy link
Copy Markdown

Deploy Preview for smartrentsystem ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6c2def5
🔍 Latest deploy log https://app.netlify.com/projects/smartrentsystem/deploys/69638ed56fc4c70008ebf630
😎 Deploy Preview https://deploy-preview-105--smartrentsystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SRUTHIAGARWAL

Copy link
Copy Markdown
Author

Hello @hitesh-kumar123 can you please go through the PR.

@SRUTHIAGARWAL

Copy link
Copy Markdown
Author

Hi @hitesh-kumar123,
The feature was working as expected on my end.
Could you please let me know what needs to be changed for this PR to be accepted?
I’d be happy to update it accordingly. Thanks!

@hitesh-kumar123

Copy link
Copy Markdown
Owner

❌ PR Closed

Thanks for the contribution.

This PR was closed because it breaks the navbar layout and responsiveness.
The icon changes disrupted the existing navbar flow, and no responsive testing or before/after screenshots were provided.

Major UI components like the navbar should not be changed without prior discussion.

You’re welcome to open a new PR with minimal, issue-focused changes and proper testing.

Screenshot 2026-01-13 230703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants