Skip to content

Fix Google OAuth login and authentication flow#100

Open
SakshiParashar29 wants to merge 1 commit into
hitesh-kumar123:mainfrom
SakshiParashar29:google-auth-fix
Open

Fix Google OAuth login and authentication flow#100
SakshiParashar29 wants to merge 1 commit into
hitesh-kumar123:mainfrom
SakshiParashar29:google-auth-fix

Conversation

@SakshiParashar29

Copy link
Copy Markdown

title: "PR: Add Google login"

Changes Made

  • Added Google OAuth login

Testing

  • Manual testing done

Checklist

  • Created branch
  • No console errors

@netlify

netlify Bot commented Jan 10, 2026

Copy link
Copy Markdown

Deploy Preview for smartrentsystem ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3170042
🔍 Latest deploy log https://app.netlify.com/projects/smartrentsystem/deploys/69628a667600e700083bbf0f
😎 Deploy Preview https://deploy-preview-100--smartrentsystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hitesh-kumar123

Copy link
Copy Markdown
Owner

@SakshiParashar29 please resolve conflicts

@Harsh63870 Harsh63870 added SWoC26 Issues and tasks related to Social Winter of Code (SWoC) contributions. Hard Authentication and Security labels Jan 11, 2026
@Harsh63870

Copy link
Copy Markdown
Collaborator

@SakshiParashar29 you have changed the version without any explanation..
architectural flaw is there in hardcoded backend url.
storing jwt in local storage is raising security concern.

@Harsh63870

Copy link
Copy Markdown
Collaborator

@SakshiParashar29 the main issue is :
the google auth flow has changed significantly (using res.credential instead of redirect-based OAuth)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Authentication and Security Hard SWoC26 Issues and tasks related to Social Winter of Code (SWoC) contributions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants