chore: upgrade Go toolchain to 1.27, drop GOEXPERIMENT=jsonv2 - #296
Closed
rsharath wants to merge 1 commit into
Closed
chore: upgrade Go toolchain to 1.27, drop GOEXPERIMENT=jsonv2#296rsharath wants to merge 1 commit into
rsharath wants to merge 1 commit into
Conversation
Go 1.27 backs encoding/json with the v2 implementation by default, so the experiment flag jwx v4 needed on 1.26 is no longer required. Bumps jwx v4 to v4.3.0 across all three modules (root, pkg/dpop, pkg/authjwt) since v4.0.x/v4.2.0 hard-fail on 1.27's finalized encoding/json/v2 API (SkipFunc was renamed); v4.3.0 handles both pre- and post-1.27 stdlib shapes. Also bumps the Docker build image to match. CI workflow YAML (.github/workflows/*.yml) still needs the matching GO_VER bump + GOEXPERIMENT removal, applied separately since this token lacks the `workflow` OAuth scope to push those files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
That was quick. 1.27 isn't available in Homebrew (yet). JSON v2 is finally here and that's great. One suggestion for the next PR is to switch to https://pkg.go.dev/uuid per https://go.dev/doc/go1.27#uuid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.mod/go.worktogo 1.27.0across all three modules (root,pkg/dpop,pkg/authjwt) and the Docker build stage image togolang:1.27.0-alpine3.24.GOEXPERIMENT=jsonv2from the Makefile and Docker build — Go 1.27 backsencoding/jsonwith the v2 implementation by default, so the experiment flag jwx v4 needed on 1.26 is no longer required.github.com/lestrrat-go/jwx/v4tov4.3.0everywhere: v4.0.x/v4.2.0 hard-fail to compile on Go 1.27's finalizedencoding/json/v2API (jsonv2.SkipFuncwas renamed to an unexported sentinel); v4.3.0 handles both the pre- and post-1.27 stdlib shapes.My GitHub token lacks the
workflowOAuth scope, so it can't push changes to.github/workflows/*.yml. CI will fail on this PR as-is (still pinned toGO_VER: "1.26.0"withGOEXPERIMENT: "jsonv2"set). Someone withworkflowscope needs to apply the equivalent change to:.github/workflows/pr-check.yml.github/workflows/release.yml.github/workflows/release-dpop.yml.github/workflows/sdk-integration.yml(bump
GO_VERto"1.27.0", delete theGOEXPERIMENT: "jsonv2"line) before this can pass and merge.Test plan
go build ./...,go vet ./...,go test ./... -shortpass on real Go 1.27.0 (root module)pkg/dpopandpkg/authjwtmodulestests/integrationfailure is pre-existing (no Docker daemon locally), unrelated to this changehighflame-docker-check— needs CI (no local Docker daemon to verify the Dockerfile build)🤖 Generated with Claude Code