Skip to content

staticaddr reregister: fixed two bugs and added test coverage #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hieblmi merged 3 commits into from
Dec 17, 2025
Merged

staticaddr reregister: fixed two bugs and added test coverage #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f2151a
staticaddr: add unit test for HTLC re-registration
starius Dec 16, 2025
ac53fbd
staticaddr: surface invoice subscription errors
starius Dec 16, 2025
44c2d04
staticaddr: clear stale HTLC confs on re-register
starius Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions staticaddr/loopin/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,10 @@ func (f *FSM) MonitorInvoiceAndHtlcTxAction(ctx context.Context,
f.Errorf("htlc tx conf chan error, re-registering: "+
"%v", err)

// A previous confirmation may no longer be valid if the
// subscription failed, so reset and wait for a fresh one.
htlcConfirmed = false

// Re-register for htlc confirmation.
htlcConfChan, htlcErrConfChan, err = registerHtlcConf()
if err != nil {
Expand Down Expand Up @@ -695,6 +699,8 @@ func (f *FSM) MonitorInvoiceAndHtlcTxAction(ctx context.Context,
case err = <-invoiceErrChan:
f.Errorf("invoice subscription error: %v", err)

return f.HandleError(err)

case <-ctx.Done():
return f.HandleError(ctx.Err())
}
Expand Down
Loading
Loading