add parser for edeka.de #1485
Open
add parser for edeka.de #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerda
approved these changes
Apr 30, 2025
Contributor
There was a problem hiding this comment.
It looks like you are using the HTML parsing for ingredients and instructions. The ingredients are nicely described in the schema, so it could be easier to access it via schema.ingredients (I think super.ingredients() does the same).
The instructions unfortunately are concated in the schema, so your approach is nicer.
Contributor
There was a problem hiding this comment.
I tested it out to extract the ingredients from the schema and they defined it in the schema badly, like "2.0 Ei" and "3.0 Frühlingszwiebel", so again your approach is nicer.
A comment why you are extracting both from the HTML instead of schema would be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.