Fix OAuth exchange attempted for repos configured before v2.4.0#1120
Merged
Fix OAuth exchange attempted for repos configured before v2.4.0#1120
Conversation
Repos configured before v2.4.0 don't have the oauth_exchange key in their saved config. The default in build_hex_core_config was true, causing hex to attempt OAuth token exchange for repos that don't support it (e.g. getoban.pro), resulting in :exchange_failed errors. Change the default to false. This is safe because hexpm repos always have oauth_exchange: true explicitly set, and repos added with v2.4.0 have it explicitly set by the add command. Also fix a test isolation issue where oauth_token from the user's actual ~/.hex/hex.config leaked into test state via init_reset_state. Closes #1119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repos configured before v2.4.0 don't have the oauth_exchange key in their saved config. The default in build_hex_core_config was true, causing hex to attempt OAuth token exchange for repos that don't support it (for example oban), resulting in :exchange_failed errors.
Change the default to false. This is safe because hexpm repos always have oauth_exchange: true explicitly set, and repos added with v2.4.0 have it explicitly set by the add command.
Also fix a test isolation issue where oauth_token from the user's actual ~/.hex/hex.config leaked into test state via init_reset_state.
Closes #1119.