Restore remaining Cargo package environment variables#32
Closed
michaelm-openai wants to merge 1 commit into
Closed
Restore remaining Cargo package environment variables#32michaelm-openai wants to merge 1 commit into
michaelm-openai wants to merge 1 commit into
Conversation
Assisted-by: Codex <noreply@openai.com>
Member
|
I'm going to drop the patch during next rebase instead, conceptually this will be landed, thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Cargo defines its package metadata environment variables even when optional manifest fields are absent. Rust targets should provide the same compile-time contract so code using
env!and derive macros can rely on those variables consistently.Validation
bazel test --nocache_test_results //test/build_env/...pre-commit run buildifier --files rust/private/rustc.bzl test/build_env/BUILD.bazelpre-commit run typos --files rust/private/rustc.bzl test/build_env/BUILD.bazel test/build_env/tests/custom_crate_name.rsrustfmt --check test/build_env/tests/custom_crate_name.rsgit diff --check