[codex] Enable LTO for Linux and Windows actiond#20
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: zbarsky-bot
Enable Zig LTO for
linux-actiondandwindows-actiond.zigopts = ["-flld", "-flto"]keeps Zig IR available to LLD, andlinkopts = ["-flto"]enables LTO in the finalcc_common.linkaction.darwin-actiondis unchanged because Zig 0.16 does not support using LLD to link Mach-O files; a final-fltoalone cannot optimize the native Zig archive.GitHub Actions run 27500458810 passed all five jobs. The Linux x86_64 LLVM smoke measured 315.286s for actiond and 316.572s for the host, a 0.996x ratio; the
maincomparison measured 269.181s and 273.404s, a 0.985x ratio. The Windows x86_64 LLVM smoke measured 323.007s for actiond and 323.048s for the host, a 1.000x ratio; themaincomparison measured 352.265s and 366.565s, a 0.961x ratio. Absolute runner times varied, so the actiond/host ratios are the relevant comparison. This single run did not show a performance improvement from LTO.Global
--copt=-fltois not included because it also changes the guest Linux kernel and confounds the actiond comparison. actiond's C dependency is zstd, which is used during VM startup rather than action execution.