Aligning implementation/specification error codes - phase 5 - #1994
Open
Roman-Manevich wants to merge 5 commits into
Open
Aligning implementation/specification error codes - phase 5#1994Roman-Manevich wants to merge 5 commits into
Roman-Manevich wants to merge 5 commits into
Conversation
Roman-Manevich
marked this pull request as ready for review
September 6, 2026 20:20
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
from
September 7, 2026 09:12
75157b6 to
e10c57c
Compare
hrutvik
reviewed
Sep 7, 2026
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
from
September 7, 2026 22:08
e10c57c to
0ce8bd6
Compare
hrutvik
reviewed
Sep 8, 2026
| [5+:0] data | ||
| }; | ||
| ASL Static error (TE_BS): | ||
| Slice 5+:0 has length 0; slice lengths must be at least 1. |
Collaborator
There was a problem hiding this comment.
I realise this is a bit misleading - it's not the case that all slices must have length of at least one (we have zero-width slices). Please could we clarify this error message to explicitly restrict the cases in which a slice length must be at least 1? I believe this is in bitfields and on left-hand sides, but please confirm.
Collaborator
Author
There was a problem hiding this comment.
Right, this is indeed for both bitfields and left hand slide slices. Perhaps
"Slice %a has length %d; but the length of this slice must be at least 1." is clearer?
HadrienRenaud
approved these changes
Sep 8, 2026
HadrienRenaud
left a comment
HadrienRenaud
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, please wait resolution on Hrutvik's side before merging
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
from
September 8, 2026 18:45
7cceb6e to
5ad9244
Compare
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
from
September 9, 2026 17:42
5ad9244 to
a16e206
Compare
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
from
September 10, 2026 11:45
a16e206 to
a9f52fc
Compare
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
2 times, most recently
from
September 10, 2026 15:38
efc90d2 to
88dfe32
Compare
Roman-Manevich
force-pushed
the
asl-error-codes-phase-5
branch
from
September 10, 2026 15:46
88dfe32 to
c41e449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify empty integer constraints
Removed a stale TODO: ASL syntax and
asl.specrequire well-constrained integers to contain at least one constraint, so the implementation's empty case is an uncoded internal invariant.Align reserved-identifier errors
Reserved identifiers now produce
BE_RIin the lexical formalism, matching the implementation.Classify invalid runtime slices
Runtime slices with a negative start or length now produce
DE_BI, matchingasl.spec; static slice failures remainTE_BSand use reason-specificbad_slicescases.