[asl] Report error codes in error messages - #1978
Merged
Merged
Conversation
HadrienRenaud
approved these changes
Sep 2, 2026
HadrienRenaud
left a comment
HadrienRenaud
left a comment
Collaborator
There was a problem hiding this comment.
I have not checked the error-codes but otherwise this looks good to me.
hrutvik
marked this pull request as ready for review
September 2, 2026 14:33
Collaborator
|
Run |
Roman-Manevich
approved these changes
Sep 2, 2026
Roman-Manevich
left a comment
Roman-Manevich
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. It just needs updating the console outputs in ErrorCodes.tex.
Collaborator
Author
Thanks, fixed - am I right in thinking that #1919 will avoid the need to run this manually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error.ErrorCodemodule, defining error codes from the referenceError.errors to error codes where possible, leaving missing cases unspecified. These will need to be handled in future PRs that align the reference document and implementation. A TODO comment captures various discrepancies.