[gen] Fixing diy test fail in "Normalize machine-size names for 64-bit and 128-bit values" - #1962
Draft
ShaleXIONG wants to merge 3 commits into
Draft
ShaleXIONG wants to merge 3 commits into
ShaleXIONG wants to merge 3 commits into
Conversation
The machSize that was previously named Quad corresponds to 64bits. This is really only double the size of Word which is 32bits. For this reason, and to avoid confusion rename it to Double. Assisted-by: OpenAI Codex <codex@openai.com> Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Follow the naming convention of the other machSize constructors and name the 128bit wide type to Quad. Assisted-by: OpenAI Codex <codex@openai.com> Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
ShaleXIONG
changed the title
diy test fail in "Normalize machine-size names for 64-bit and 128-bit values"
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
diytest due to the annotation name change:Quad, i.e.,qbecomeDouble, i.e.,d.