fix: harden MLX generation path with staged errors and terminal stream events - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PostHog data for July 7 to August 6, 2026 showed that all recorded MLX replies failed. Failed replies gave no error detail, no failure stage, and no elapsed time. This PR hardens the common generation path in the module.
Changes
LLMError.alreadyGenerating. Overlapping generations on one MLX container can no longer occur.LLMErrordescriptive. It now conforms toLocalizedErrorand carries a failure stage:prepare,generate,tool, orhistory. JS receives a real error message.generation_errorterminal stream event. On failure,streamWithEventsemits the error message, the stage, and partial stats with the real elapsed time. The promise still rejects.stop()or a newload()ends the stream with a terminalgeneration_endevent and partial stats.stageenvelope field.Tests
mapStreamEventEnvelopetests. All 12 pass.LLMErrorTestsbinary (bun test:ios-llm-error). Passes.MLXReactNativepod compiles for iOS in the example workspace.Notes
streamWithEventscall now ends with exactly one terminal event. Analytics can record real failure time and stage.https://claude.ai/code/session_01DgCfBw3xKnd12KjNkGLcuV