[Sonic Frontiers] Converse: fix OOB reads, use-after-free and memory leak#264
Merged
Conversation
Merged
Contributor
|
Unfortunately still seems to crash with the |
Member
Author
I've been able to replicate this on Windows and it does appear to be a fault with the Converse library. Looking into it. |
…ring The game copies the string using a fixed length, rather than using a terminator.
Member
Author
|
@Mefiresu Tutorial Skip should work now, please test again using the latest |
|
Looks to be behaving properly now, 5/5 runs with no crashes. |
ee4d9b6 to
3f6baab
Compare
Co-authored-by: Sajid <sajidur78@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR addresses three critical issues in the hook initialised by the Converse library.
This fix needs testing on Linux, as these issues were made more apparent there, but these flaws would also affect Windows too.