Add newtype Salign

[chris-martin]

I've always been frustrated that base has ZipList in Control.Applicative that can give you a list-zipping Applicative, but no corresponding newtype in Data.Semigroup that would give you a list-zipping Semigroup.

This seems like it could be a nice place to put (a more general version of) such a thing -- a Salign type right next to the salign function. I think it'd be very nice to use in conjunction with DerivingVia to define types with aligning semigroups.

[phadej]

Note that it's a Monoid too. I'd also like those instances http://hackage.haskell.org/package/base-4.12.0.0/docs/Data-Monoid.html#t:Ap

…

Sent from my iPhone

On 12 Feb 2019, at 2.39, Chris Martin ***@***.***> wrote: I've always been frustrated that base has ZipList in Control.Applicative that can give you a list-zipping Applicative, but no corresponding newtype in Data.Semigroup that would give you a list-zipping Semigroup. This seems like it could be a nice place to put (a more general version of) such a thing -- a Salign type right next to the salign function. I think it'd be very nice to use in conjunction with DerivingVia to define types with aligning semigroups. You can view, comment on, or merge this pull request online at: #104 Commit Summary Add newtype Salign File Changes M Data/Align.hs (8) M test/Tests.hs (7) Patch Links: https://github.com/isomorphism/these/pull/104.patch https://github.com/isomorphism/these/pull/104.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[chris-martin]

Added the Monoid instance.

You want Salign to have instances of all these? Alternative, Applicative, Enum, Eq, Functor, Generic, Generic1, Monad, MonadFail, MonadPlus, Ord, Read, Show

[phadej]

I'd leave Applicative and subclasses, but have everything else Functor/Foldable/Traversable

…

Sent from my iPhone

On 12 Feb 2019, at 3.05, Chris Martin ***@***.***> wrote: Added the Monoid instance. You want Salign to have instances of all these? Alternative, Applicative, Enum, Eq, Functor, Generic, Generic1, Monad, MonadFail, MonadPlus, Ord, Read, Show — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.