hclwrite: body.SetAttribute* return new attribute#806
Open
bbasata wants to merge 2 commits into
Open
Conversation
This change updates Body.SetAttribute* to return the new attribute rather than return nil. This matches the intent in the documentation comments that indicate: The return value is the attribute that was either modified in-place or created.
Collaborator
Author
|
TIL: #613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change updates
hclwrite.Body.SetAttribute*to return the new attribute rather than returnnil.This matches the intent in the documentation comments that indicate:
An available workaround:
Open question: I'm considering whether to check the return value of
Body.SetAttribute*inhclwrite/ast_body_test.go.