fix(components): remove ember-source as peerDep#2899
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aklkv
force-pushed
the
fix/drop-ember-source-peer-as-dep
branch
from
e311a1a to
1b1f6a3
Compare
didoo
approved these changes
May 23, 2025
alex-ju
reviewed
May 27, 2025
Comment on lines
-122
to
-124
| "peerDependencies": { | ||
| "ember-source": "^3.28.0 || ^4.0.0 || ^5.3.0" | ||
| }, |
Member
Collaborator
Author
There was a problem hiding this comment.
For this particular dependencies it's probably not possible as it is problematic. Follow linked issue for more details. Maybe if you ask that question there. But we can/should specify support range in the docs. At the same time our support rage is too wide as it is I wouldn't worry too much about potential issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This follows this set of issues ember-cli/ember-addon-blueprint#35 which gives comprehensive reasoning for why
From PR descriptions elsewhere:
ember-source: removed because the embroider / auto-import know what we intend - it's not bad to have if someone manages their dep graph correctly, which is easier with pnpm, but not everyone gets it right, and folks have a hard time tracking down errors@glimmer/trackingremoved because it's a real package, but one we don't want to use. This comes up inembroider/vitewhere the presence of real packages always takes precedence over virtual packages. This is actually problematic because it can break reactivity in subtle ways, even if a dep graph is correct - allowing duplicates of dependencies, which for the glimmer internals, we don't want.🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.