Use real ButtonV2 prop values in the Skills tab

[kateebonner]

What

Unblocks bun typecheck on local/amicode.

The Skills tab (a6c8255, amicode #573) uses four size values and three
variant values that are not in ButtonV2's unions:

size?: "small" | "normal" | "large"
variant?: "neutral" | "danger" | "warning" | "outline" | "contrast" | "ghost" | "ghost-muted" | "loading"

"xs", "sm" and "secondary" are none of those, so the workspace has failed
typecheck with 7 errors since it merged.

Why it matters beyond the errors

.husky/pre-push runs a full-workspace bun typecheck. So this has been
blocking pushes on every branch in the fork, not just its own — anyone who
hit it had to either stop or reach for --no-verify, which is how genuine
breakage slips through later. (#258 needed exactly that bypass for its final
push, disclosed there.)

The change

Seven call sites in one file, mapped to the values the rest of settings-v2
already uses rather than to my preference:

was	now	precedent in settings-v2
size="xs" / size="sm"	size="small"	13 existing uses
variant="secondary"	variant="neutral"	10 existing uses

Every invalid value in the whole settings-v2 directory was in this one file,
so this brings it in line with its siblings. Rendering is unchanged in intent —
these are the nearest real names for what the markup was already asking for.

Verified

• bun typecheck — 30/30 tasks, workspace clean. First green since #573.
• bun run check:design — passes.
• bun run lint — 5366 warnings / 1 error, byte-identical to base; adds nothing.
• Pre-push hook passes without --no-verify.

Note for the author

@ the #573 author — flagging rather than assuming: I picked neutral for the
three secondary buttons (Add directory, Autodiscover, and the discovered-row
action) because it is the settings-v2 default. If you meant those to read as
lower-emphasis than the primary action, ghost-muted is the other established
choice and is what the one other in-row action uses. Happy to switch.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c5c75e6d-4fd0-460d-a0dd-8afad33b6e43

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}