Skip to content

fix: ignore promotion workflow checks - #484

Merged
jack-champagne merged 1 commit into
mainfrom
fix/promote-self-check
Aug 21, 2026
Merged

fix: ignore promotion workflow checks#484
jack-champagne merged 1 commit into
mainfrom
fix/promote-self-check

Conversation

@jack-champagne

@jack-champagne jack-champagne commented Aug 21, 2026

Copy link
Copy Markdown
Member

The previous promotion attempt left a failed promote check on the alpha commit. Ignore promote workflow check entries in addition to pending checks; continue rejecting failed build and test checks.

Summary by CodeRabbit

  • Bug Fixes
    • Promotion checks now correctly exclude the promotion workflow’s own check when evaluating alpha commit status.
    • Existing validation and release-tagging behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d0dc36e-52ed-45f6-aa79-d630f3797ba1

📥 Commits

Reviewing files that changed from the base of the PR and between fbd1e61 and cd02a7d.

📒 Files selected for processing (1)
  • .github/workflows/promote.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The promotion workflow now excludes the promote check run when counting non-green checks on the alpha commit. Other validation and release-tagging behavior remains unchanged.

Changes

Promotion validation

Layer / File(s) Summary
Filter promotion check results
.github/workflows/promote.yml
The non-green check count ignores the promote check run while continuing to reject other non-success, non-skipped, and non-neutral conclusions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cd02a

The change is localized to promotion workflow check handling, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: ignoring promotion workflow checks during promotion validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/promote-self-check

Comment @coderabbitai help to get the list of available commands.

@jack-champagne
jack-champagne merged commit d742b19 into main Aug 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant