♻️ refactor(mq-lang): clean up tarn VM compiler error messages and dead_code - #2305
Merged
Conversation
…ad_code Drop the leftover "vm M2 subset" wording from CompileError's Display, remove the never-constructed UnsupportedExpr variant, and replace allow(dead_code) workarounds with #[cfg(test)] on helpers only used by tests (compile_program, compile_program_with_builtin_prelude, compile_and_run, compile_and_run_full, interpreter::run). Also drop a stale dead_code annotation on VmError::token_id, which is actually used in production via vm_error_to_runtime_error. Also extract the three destructuring-pattern fields on Compiler (or_pattern_slots, pending_pattern_overrides, current_pattern_override) into a PatternState substruct to shrink the struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop the leftover "vm M2 subset" wording from CompileError's Display, remove the never-constructed UnsupportedExpr variant, and replace allow(dead_code) workarounds with #[cfg(test)] on helpers only used by tests (compile_program, compile_program_with_builtin_prelude, compile_and_run, compile_and_run_full, interpreter::run). Also drop a stale dead_code annotation on VmError::token_id, which is actually used in production via vm_error_to_runtime_error.
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context