Skip to content

feat(books): Delete and edit book#31

Open
emisansev wants to merge 8 commits intodevfrom
feat/deleteBook
Open

feat(books): Delete and edit book#31
emisansev wants to merge 8 commits intodevfrom
feat/deleteBook

Conversation

@emisansev
Copy link
Copy Markdown
Contributor

No description provided.

@emisansev emisansev requested review from jorge-sanz and josedl4 May 23, 2017 20:51
Comment thread src/app/books/book.service.ts Outdated
.then((response) => {
console.log(response);
return response.json().data as Book[];
.then(response => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want change this? It is necessary for something

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just a something I have misplaced. I'll check it out just in case

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done now. You were right.

@Output() _delete: EventEmitter<number> = new EventEmitter();
/*closeResult: string;*/

constructor(private modalService: NgbModal) { }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this argument?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a change I made on the name. I'll check it again.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's done now. You were right.

Copy link
Copy Markdown
Contributor Author

@emisansev emisansev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necesario para aplicar los cambios que me comentó Jose

@Output() _delete: EventEmitter<number> = new EventEmitter();
/*closeResult: string;*/

constructor(private modalService: NgbModal) { }
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a change I made on the name. I'll check it again.

Comment thread src/app/books/book.service.ts Outdated
.then((response) => {
console.log(response);
return response.json().data as Book[];
.then(response => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just a something I have misplaced. I'll check it out just in case

@jorge-sanz jorge-sanz changed the title feat/deletebook FIXED feat(books): Delete book May 24, 2017
@emisansev emisansev changed the title feat(books): Delete book feat(books): Delete and edit book May 24, 2017
Copy link
Copy Markdown
Member

@jorge-sanz jorge-sanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't run with dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants