#11 Use JSON files for config storage#22
Open
robberwick wants to merge 3 commits intohackhitchin:masterfrom
Open
#11 Use JSON files for config storage#22robberwick wants to merge 3 commits intohackhitchin:masterfrom
robberwick wants to merge 3 commits intohackhitchin:masterfrom
Conversation
worlds6440
requested changes
Mar 24, 2017
Contributor
worlds6440
left a comment
worlds6440
left a comment
There was a problem hiding this comment.
Hi Rob, you may want to re-pull the Calibration from Master as it had moved on a fair amount. We've added a few more servos / ESCs so I'd be interested in seeing how it copes with that.
Author
|
Will do... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should be a drop-in replacement for the existing config.ini, replacing it with a JSON file instead.
I don't have a test setup here to check it with, so please consider this a pre-PR PR for testing purposes.
@worlds6440 would you be so kind as to take a butchers at it?