refactor: Use CommandLineToArgvW equivalents to parse args line#4
Open
fuweichin wants to merge 2 commits intohaath:masterfrom
Open
refactor: Use CommandLineToArgvW equivalents to parse args line#4fuweichin wants to merge 2 commits intohaath:masterfrom
fuweichin wants to merge 2 commits intohaath:masterfrom
Conversation
The goal of this change is to parse nginx configure arguments which can be get by `nginx -V`. TODO Tests need to be updated. BREAKING CHANGE: quote with single quotes are not supported, double quote escaping and backslash escaping.
Allow double-quotes and spaces when separators are set to equal (=) and/or colon (:), base on previous commit "refactor: Use CommandLineToArgvW equivalents to parse args line". This maybe a BREAKING CHANGE, empty arg values are also allowed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this change is to parse nginx configure arguments which can be get by
nginx -V.TODO This PR isn't ready to be merged to the master branch directly, I hope someone checkout the commit, update the tests and merge the changes. I'm using Visual Studio 2022, so some old targets (like .net45,.netstandard1.6) may not be covered.
BREAKING CHANGE: quote with single quotes are not supported, comes double quote escaping and backslash escaping.