Repository navigation
Update to latest S3Mock, which uses the updated testcontainers for Docker v29+ - #147
Merged
Merged
Conversation
…Docker v29+ This means we can undo the temporary fix we added with: * #136 We no longer need to explcitely require a newer version of `testcontainers`, as the latest release of S3Mock already pulls in a sufficiently new version of `testcontainers`, that works with Docker v29+: * adobe/S3Mock#2962 * https://github.com/adobe/S3Mock/releases/tag/4.12.4 # Conflicts: # build.sbt
rtyley
force-pushed
the
update-to-latest-s3mock-for-docker-v29
branch
from
April 30, 2026 13:16
d0693e7 to
a4408f9
Compare
rtyley
marked this pull request as ready for review
April 30, 2026 13:56
kelvin-chappell
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently merged an update to S3Mock (
com.adobe.testing:s3mock-testcontainers):This means we can undo the temporary fix that explicitly added a newer version of
org.testcontainers:testcontainerswith:testcontainersto a version that works with Docker v29 #136We no longer need to explicitly require a newer version of
testcontainers, as the latest release of S3Mock already pulls in a sufficiently new version oftestcontainers, that works with Docker v29+:testcontainerscompatible with Docker v29+ adobe/S3Mock#2962