Skip to content

Remove outdated note about performance - #586

Merged
rymai merged 1 commit into
guard:masterfrom
quadule:patch-1
Oct 1, 2026
Merged

rymai merged 1 commit into
guard:masterfrom
quadule:patch-1

Conversation

@quadule

@quadule quadule commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

Silenced directories aren't recorded since #544, so ignoring large directories like .git and node_modules can improve performance.

Silenced directories are no longer recorded after
8b17254
@LouisaNikita

LouisaNikita commented Jan 17, 2025 via email

Copy link
Copy Markdown

@rymai

rymai commented Sep 30, 2026

Copy link
Copy Markdown
Member

I don't think #544 is related to performance here. Closing, but please feel free to reopen and explain further if needed.

@rymai rymai closed this Sep 30, 2026
@quadule

quadule commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

@rymai Sorry, it was #542 in 2021 that improved performance for silenced directories. This note in the readme came from 4353ed4 back in 2014, so I don't think it's correct anymore.

@rymai rymai reopened this Oct 1, 2026
@rymai

rymai commented Oct 1, 2026

Copy link
Copy Markdown
Member

Makes sense! LGTM, thanks! ❤️

@rymai
rymai merged commit 751b3f8 into guard:master Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants