Bemb chunked first cut#25
Open
kanodiaayush wants to merge 20 commits into
Open
Conversation
TODO 1. check rehshaping code 2. add reshaping for other coeffs 3. fix printing code 4. fix code for log variational (although this probably never needs to be done as we never need to use `trace_log_q`)
run python main.py configs3_1.yaml in tutorials/supermarket to test removed lognormal from bemb.py, will remove from bemb_chunked.py too
1. the hyperprior is gaussian 2. the prior is gaussian 3. the lower bound of the lognormal is lowered 4. handling is changed to make it clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
take a look and tell me what you think of this @TianyuDu