Fix model configuration schema to consistently use [models]#207
Closed
gregorriegler wants to merge 4 commits intomainfrom
Closed
Fix model configuration schema to consistently use [models]#207gregorriegler wants to merge 4 commits intomainfrom
[models]#207gregorriegler wants to merge 4 commits intomainfrom
Conversation
The configuration previously required `[model]` for the default setting and `[models.*]` for specific configurations. This was inconsistent and caused confusion as noted in the README. This change updates `simple_agent/infrastructure/model_config.py` to parse the `default` key directly from the `[models]` section. All example configuration files and the README have been updated to reflect the new consistent schema. Test suites were also updated to pass with the new schema. Co-authored-by: gregorriegler <5053662+gregorriegler@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added `await pilot.pause()` immediately after entering the `app.run_test()` context in `test_continuation_tool_result_is_last_event`. This ensures the UI layout engine fully processes and renders docked widgets like `SmartInput` and inner `Markdown` elements before capturing the state, resolving an `Approval Mismatch` seen on Windows CI. Co-authored-by: gregorriegler <5053662+gregorriegler@users.noreply.github.com>
Textual's `Markdown` widget parses its content asynchronously in a background worker. On slower systems (like Windows CI runners), `await pilot.pause()` wasn't sufficient to guarantee the worker had completed before capturing the golden UI state. This resulted in an `Approval Mismatch` where the DOM still had raw unparsed `Markdown` nodes instead of the expected `MarkdownParagraph` elements. This change adds `await app.workers.wait_for_complete()` before `await pilot.pause()` in `continuation_ui_golden_test.py` to ensure all asynchronous Markdown parsing and rendering finishes before snapshotting the UI state. Co-authored-by: gregorriegler <5053662+gregorriegler@users.noreply.github.com>
…on Windows CI. Within the test checking that the application sends user input, the action method responsible for dispatching this input queues asynchronous work to expand the context and send the data. On slower CI runners (Windows), a basic `await pilot.pause()` was occasionally returning before the worker and message queue fully settled, leading to an assertion failure because the captured input records were empty. I added `await app.workers.wait_for_complete()` and a short delay (`await pilot.pause(0.1)`) to ensure the dispatch event has time to fully process before assertions. Co-authored-by: gregorriegler <5053662+gregorriegler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix configuration parsing logic to parse
defaultfrom the[models]section and updated configuration documentation and test examples.PR created automatically by Jules for task 8337077536644701292 started by @gregorriegler