Repository navigation
fix(gmp): protect report-scoped result filtering - #872
Open
hive-bumblebee wants to merge 2 commits into
Open
hive-bumblebee wants to merge 2 commits into
hive-bumblebee wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #871; provides the upstream typed filtering prerequisite for greenbone/rust-gvm-api#741.
compose_report_results_filter(&EntityId, Option<&str>, Option<&str>, Pagination) -> Result<String, ReportResultsFilterError>: accepts resolved saved and inline filter text, protects report isolation using gvmd's independent report restriction, and owns pagination.Verification
Using
/workspace/866-test-envand isolatedCARGO_TARGET_DIR=/workspace/.cache/upstream-filter-target:cargo fmt --all -- --checkpassed.-D warnings) passed for touched GMP/mock/client libraries and test targets.A broader
--all-targetsClippy attempt encounters the existing missing-crate-documentation warning incrates/gvm-gmp/tests/agent_schedule_serde_test.rs; unrelated tests were not modified. Existing Cargo manifest unused-workspace-dependency warnings remain.Originally based on the full #868 stack at b6f33da; rebased the single incremental change onto main after #868 was merged (squashed stack, equivalent baseline tree). Saved-filter arguments are resolved term text; callers must leave request
filter_idunset so gvmd does not replace the composed inline filter.Agent: b02-agent-035