update members page - core / leaders / contributors#165
Open
dedece35 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the “Notre collectif” (members) page by introducing a dedicated “Technical Leaders” section and adjusting the underlying member datasets (core members vs contributors), along with a UI tweak to display technical leadership information per member.
Changes:
- Add a new “Technical Leaders” section to the collective view and load members from a new JSON dataset.
- Update member card UI to display technical-leading information.
- Reclassify some people between
contributors.jsonandcore-members.json, and add the newtechnical-leaders.jsondataset.
Reviewed changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/views/CollectiveView.vue |
Adds import + new section for Technical Leaders between Core team and Contributors. |
src/components/collective/Member.vue |
Attempts to render “technical-leading” info on member cards. |
src/assets/data/technical-leaders.json |
Introduces the Technical Leaders dataset (new file). |
src/assets/data/core-members.json |
Adds/moves members into core team dataset. |
src/assets/data/contributors.json |
Removes members moved into core/technical leader roles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+56
to
+60
| <div class="info" v-if="technical-leading"> | ||
| <p class="technical-lead"> | ||
| <span v-for="tec in technical-leading">{{ tec }}<br/></span> | ||
| </p> | ||
| </div> |
Comment on lines
2
to
12
| { | ||
| "name": "Vianney de Bellabre", | ||
| "company": "C2S Bouygues", | ||
| "profile": "vianney_de_bellabre.webp", | ||
| "links": { | ||
| "linkedin": "vianney-de-bellabre", | ||
| "github": "Djoums" | ||
| } | ||
| },{ | ||
| "name": "David De Carvalho", | ||
| "company": "Capgemini", |
Comment on lines
+8
to
+12
| "github": "ashvinappi24-cmd" | ||
| }, | ||
| "technical-leading" : ["ecoSonar"] | ||
| },{ | ||
| "name": "Vianney de Bellabre", |
| }, | ||
| { | ||
| "name": "Florian Stormacq", | ||
| "company": "Univversité de NAMUR", |
Member
|
Hey @dedece35 👋 Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.