Skip to content

feat(design, storefront)!: move DaffQuantityFieldComponent into the storefront package#4121

Merged
damienwebdev merged 5 commits intodevelopfrom
quantity-field-update
Mar 6, 2026
Merged

feat(design, storefront)!: move DaffQuantityFieldComponent into the storefront package#4121
damienwebdev merged 5 commits intodevelopfrom
quantity-field-update

Conversation

@xelaint
Copy link
Copy Markdown
Member

@xelaint xelaint commented Oct 9, 2025 •
edited
Loading

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Replace inputs with signals in order to handle focus changes.

Currently, focus does not transition when select changes to an input.

Fixes: #3888
Part of: #416, #3799

New behavior

Breaking change?

  • Yes
  • No

BREAKING CHANGE: The quantity field component has been moved from @daffodil/design to @daffodil/storefront.

Additional context

@xelaint xelaint requested a review from damienwebdev October 9, 2025 18:06
@xelaint xelaint added package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft. labels Oct 9, 2025
@xelaint xelaint changed the title feat(design): implement DaffFormFieldControl in DaffQuantityFieldComp… feat(design): implement DaffFormFieldControl in DaffQuantityFieldComponent Oct 9, 2025
@xelaint xelaint changed the title feat(design): implement DaffFormFieldControl in DaffQuantityFieldComponent feat(design)!: implement DaffFormFieldControl in DaffQuantityFieldComponent Oct 9, 2025
@xelaint xelaint added the 🚨 breaking changes This PR or issue will cause a breaking change label Oct 9, 2025
@xelaint xelaint mentioned this pull request Nov 14, 2025
Closed
7 tasks
@xelaint xelaint force-pushed the quantity-field-update branch 2 times, most recently from eca7788 to 32dfffa Compare November 21, 2025 14:51
@xelaint xelaint marked this pull request as ready for review November 21, 2025 14:52
@xelaint xelaint requested review from a team as code owners November 21, 2025 14:52
@xelaint xelaint force-pushed the quantity-field-update branch 2 times, most recently from 43b2266 to 96e82e5 Compare November 24, 2025 21:30
@xelaint xelaint requested review from a team as code owners November 24, 2025 22:03
@xelaint
Copy link
Copy Markdown
Member Author

xelaint commented Nov 24, 2025

@damienwebdev moved quantity field to @daffodil/storefront. This is ready for final review.

@xelaint xelaint changed the title feat(design)!: implement DaffFormFieldControl in DaffQuantityFieldComponent feat(design, storefront)!: move DaffQuantityFieldComponent into the storefront package Nov 24, 2025
@xelaint xelaint added status: pending review This PR is awaiting review or response from a reviewer before the author can proceed. and removed status: wip This PR is WIP. It should be marked as a draft. labels Nov 24, 2025
damienwebdev
damienwebdev requested changes Dec 4, 2025
View reviewed changes
Comment thread libs/design/form-field/src/form-field/form-field.component.scss Outdated
Comment thread libs/design/form-field/src/form-field/form-field.component.ts Outdated
@xelaint xelaint requested a review from damienwebdev December 8, 2025 14:24
@xelaint xelaint mentioned this pull request Dec 29, 2025
Open
@xelaint xelaint force-pushed the quantity-field-update branch from 001b7f6 to a118c83 Compare February 10, 2026 17:04
damienwebdev
damienwebdev requested changes Feb 24, 2026
View reviewed changes
Comment thread libs/storefront/quantity-field/src/quantity-field.ts
Comment thread libs/storefront/quantity-field/src/quantity-field.module.ts Outdated
Comment thread libs/storefront/quantity-field/src/quantity-field.component.ts Outdated
Comment thread libs/storefront/quantity-field/src/quantity-field.component.ts Outdated
Comment thread libs/storefront/quantity-field/src/quantity-field.component.ts Outdated
Comment thread libs/design/quantity-field/README.md
Comment thread libs/design/native-select/src/native-select/native-select.component.ts
Comment thread libs/design/input/src/input.component.ts
Comment thread libs/design/form-field/src/form-field/form-field.component.scss
Comment thread libs/design/form-field/src/form-field/form-field.component.ts Outdated
@xelaint xelaint force-pushed the quantity-field-update branch 3 times, most recently from 97fa602 to c4b1506 Compare February 24, 2026 22:33
@xelaint xelaint requested a review from damienwebdev February 24, 2026 22:34
@xelaint xelaint force-pushed the quantity-field-update branch 3 times, most recently from 93ced54 to d17a8ca Compare March 3, 2026 17:46
@xelaint xelaint force-pushed the quantity-field-update branch 2 times, most recently from a9e5fc2 to 466635e Compare March 6, 2026 14:36
damienwebdev
damienwebdev requested changes Mar 6, 2026
View reviewed changes
Comment thread libs/design/quantity-field/src/quantity-field.component.ts Outdated
Comment thread libs/design/textarea/src/textarea.component.ts
Comment thread libs/design/native-select/src/native-select/native-select.component.ts
Comment thread libs/design/input/src/input.component.ts
Comment thread .../design-examples/quantity-field/src/basic-quantity-field/basic-quantity-field.component.html
Comment thread apps/daffio/src/app/docs/design/examples/content.provider.ts
@xelaint xelaint force-pushed the quantity-field-update branch from 994bbe5 to 1ff6586 Compare March 6, 2026 18:12
@xelaint xelaint requested a review from damienwebdev March 6, 2026 18:12
damienwebdev
damienwebdev approved these changes Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit df6d19d into develop Mar 6, 2026
13 checks passed
@damienwebdev damienwebdev deleted the quantity-field-update branch March 6, 2026 19:51
@gray-bot gray-bot mentioned this pull request Mar 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damienwebdev damienwebdev damienwebdev approved these changes

Assignees

@damienwebdev damienwebdev

Labels

🚨 breaking changes This PR or issue will cause a breaking change package: design @daffodil/design status: pending review This PR is awaiting review or response from a reviewer before the author can proceed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update DaffQuantityFieldComponent implementation according to new DaffFormFieldComponent API

2 participants

@xelaint @damienwebdev