Conversation
Contributor
|
The latest changes of this PR are not available as |
kamilkisiela
pushed a commit
to robbin-norberg-vcc/federation-composition
that referenced
this pull request
Sep 9, 2026
…reachable types from schema contracts (graphql-hive#329) Preserve type referenced by directive arguments when removing unreachable types from schema contracts We did not traverse the directive definitions before. Closes graphql-hive#330
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, an invalid schema can be produced because a composed directive's arguments are flagged as
@inaccessibleThis change takes directive arguments into account so that the schema produced is valid.
Closes #329