refactor: Remove multinetwork #1153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check-formatting.yml: checkout@v2 → v4, [email protected] → v4 - ci.yml: checkout@v2 → v4, setup-node@v1 → v4 Resolves deprecation warnings for Node.js 16 actions
- checkout@v2 → v4 - codeql-action/init@v1 → v3 - codeql-action/autobuild@v1 → v3 - codeql-action/analyze@v1 → v3
- Replace deprecated crazy-max/ghaction-docker-meta@v1 with docker/metadata-action@v5 - Update tag configuration to use new metadata-action format - docker/setup-qemu-action@v1 → v3 - docker/setup-buildx-action@v1 → v3 - docker/login-action@v2 → v3 - docker/build-push-action@v2 → v6 - actions/setup-python@v4 → v5 - actions/[email protected] → v4 - actions/checkout@v2 → v4
- check-formatting.yml: Node 20 → 24 - ci.yml: test matrix [20, 22] → [22, 24] - indexer-agent-image.yml: Node 20 → 24 - indexer-cli-image.yml: Node 20 → 24
- Remove 'indexer cost set variables' from expected CLI output - This command doesn't exist (no variables.ts file in cost/set/) - Fixes failing cost.test.ts that expected output without this line Reverts incorrect changes from commit 272d624
- Remove 'indexer cost set variables' from expected CLI output - This command doesn't exist (no variables.ts file in cost/set/) - Restore proper trailing whitespace alignment - Fixes failing cost.test.ts and cli.test.ts Reverts incorrect changes from commit 272d624
- Add getNetwork() to get network from context - Add getProtocolNetwork() to resolve optional protocolNetwork parameter - These helpers simplify resolver code by centralizing network resolution
- Update all resolvers to use getNetwork()/getProtocolNetwork() helpers - protocolNetwork parameter now defaults to configured network - Removes need for clients to always specify network
- Change from MultiNetworks<Network> to single Network - Simplify internal logic that previously iterated over networks - Update action and rule management to work with single network context
- Replace multiNetworks option with single network - Update IndexerManagementResolverContext to use Network instead of MultiNetworks - Simplify client creation and context passing
- Update command helpers to handle optional protocolNetwork - CLI commands no longer require --network flag when only one network configured
- Replace MultiNetworks<NetworkAndOperator> with single network/operator - Remove NetworkAndOperator type, simplify AgentConfigs - Simplify reconciliationLoop() - remove NetworkMapped types - Update syncing server to take single network instead of record - Remove complex zip/mapNetworkMapped operations
- Rename setupMultiNetworks/setupSingleNetwork to setupNetwork - Remove MultiNetworks usage from test setup - Remove consolidateAllocationDecisions test (function removed) - Tests now use single network configuration
- Delete multi-networks.ts file - Remove export from index.ts - Multi-network support fully removed from codebase
- check-formatting.yml: Node 20 → 24 - ci.yml: test matrix [20, 22] → [22, 24] - indexer-agent-image.yml: Node 20 → 24 - indexer-cli-image.yml: Node 20 → 24
- Remove 'indexer cost set variables' from indexer-cost.stdout - Remove 'indexer cost set variables' from indexer-help.stdout Part of refactor: remove multi-network support
dwerner
force-pushed
the
refactor/remove-multinetwork-for-reals
branch
from
ba554e6 to
6e97989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1152