Conversation
Kara-Zor-El
requested review from
alex-snezhko,
marcusroberts,
ospencer,
peblair,
phated and
spotandjake
as code owners
July 10, 2026 19:40
spotandjake
approved these changes
Jul 10, 2026
wasi/File module
Member
|
Are there any tests we can add here? |
Member
I'm pretty sure this is covered by our issue to enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was noticed that
Fs.existswas throwing an uncaught error and while looking into that error it was also noticed that doing--dir=.instead of--dir=./caused another similar uncaught error.The problem relating to
Fs.existsstemmed from a couple of out of bounds reads that were solved by checking if we are past the boundary of the string before rather than after, this bug existed before the gc work however as we are now using gc arrays which are bounds checked the error surfaced.The problem with the preopens stemmed from
stripPrefixwe were mistaking checking for./before.which led to an overread similar to before this error never surfaced before the gc work as linear memory isn't bounds checked.