chore(compiler): Cleanup swap code in compcore#2390
Open
spotandjake wants to merge 1 commit into
Open
Conversation
spotandjake
requested review from
alex-snezhko,
peblair and
phated
as code owners
April 30, 2026 19:41
ospencer
approved these changes
May 3, 2026
spotandjake
force-pushed
the
oscar/gc-rebased
branch
from
May 10, 2026 21:23
35e071d to
7354757
Compare
I noticed that we had three functions for handling swap that all do bassically the exact same thing with a different action. I pulled this shared logic out into a shared helper function.
spotandjake
force-pushed
the
spotandjake/swap-cleanup
branch
from
May 10, 2026 21:30
512b75d to
6e32e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we had three functions for handling swap that all do bassically the exact same thing with a different action. I pulled this shared logic out into a shared helper function.
This work is based on: #2378
Work towards: #85