[DirectVerbs] Implement wait-related interfaces in the dv transport#107
Open
pakmarkthub wants to merge 80 commits intogpudirect:devel-dvfrom
Open
[DirectVerbs] Implement wait-related interfaces in the dv transport#107pakmarkthub wants to merge 80 commits intogpudirect:devel-dvfrom
pakmarkthub wants to merge 80 commits intogpudirect:devel-dvfrom
Conversation
…emoved res_domain from the gds_qp struct
…p/cq functions to mlx5-exp
…er an opaque struct
…t changes in gdsync.cpp
|
I have question, if this update works, it seems libmp need to update too, because it used old structure of libgdsync |
Contributor
Author
|
Hi @hongbilu, Yes, we need to update libmp too. The patch for libmp is not ready yet, however. Do you want to use libmp also? |
yeah,very expect for it which must be cool to support ofed 5.4. BTW, i saw that nvshmem and GPUnetIO library also support gdasync too, it seems a little repeated, and I support this project because I feel it is a offical library only for gdasync |
|
@pakmarkthub hi,why not use mlx5dv_devx_obj_create instead of mlx5_dv_create_cq? The "struct mlx5_ifc_create_cq_in_bits" seems disappear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites:
This PR:
gds_poll_cq.gds_poll_cqinstead ofibv_poll_cq.Notes:
IBV_WR_SENDis the only opcode that is supported. And it works with only non inline data.Presubmit testing: