feat(guardian): introduce new guardian jobs - #32
Open
rahmatrhd wants to merge 5 commits into
Open
Conversation
bsushmith
reviewed
Aug 1, 2023
| @@ -59,6 +59,22 @@ app: | |||
| - job | |||
| - run | |||
| - appeal_expiration_revocation | |||
Collaborator
There was a problem hiding this comment.
We need to update the appeal expiration related jobs also to grant related ones.
bsushmith
reviewed
Aug 1, 2023
Comment on lines
101
to
103
| JOBS_REVOKE_EXPIRED_ACCESS_INTERVAL: "*/20 * * * *" | ||
| JOBS_EXPIRING_ACCESS_NOTIFICATION_ENABLED: false | ||
| JOBS_EXPIRING_ACCESS_NOTIFICATION_INTERVAL: "0 9 * * *" |
Collaborator
There was a problem hiding this comment.
can we add grant related flags also here?
Member
Author
There was a problem hiding this comment.
those are optional, we can omit them from here
Collaborator
There was a problem hiding this comment.
Sure. Some of these existing ones are deprecated if I recall correctly. Can we remove the deprecated ones also.
Member
|
@rahmatrhd let's update to the last app chart and populate |
bsushmith
reviewed
Aug 30, 2023
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "0.3.0" # TODO: update with latest version | ||
| appVersion: "0.7.5-beta.2" |
Collaborator
There was a problem hiding this comment.
Can we include the latest stable release instead of -beta version one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on: goto/guardian#56