feat: add delete message undo #903
Conversation
Co-authored-by: AlliotTech <[email protected]>
jmattheis
force-pushed
the
pending-deletes
branch
from
cf268a7 to
7bd057c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 56 56
Lines 2226 2226
=======================================
Hits 1762 1762
Misses 360 360
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should we implement this for delete all messages as well? That seems like a much easier (and higher impact) mistake to make? |
| }; | ||
|
|
||
| const renderMessages = () => ( | ||
| // Virtuoso logs errors when elements have 0px size as this normally means it's miscalculated. |
There was a problem hiding this comment.
I think that error meant when that element is needed for scrollbar positioning it will not work.
If you send more than a page of messages, scroll to the bottom and start clicking delete the scrollbar has a lot of "jumping" glitch/error that weren't there on master branch.
Reproduction:
- shell script send 100 messages, call them "message $i"
- scroll to the bottom
- click the delete button on the message and the end of the viewport on master you should be clicking "1, 2, 3, 4, ..." sequentially, on this branch it is very random
There was a problem hiding this comment.
I think just .filter() should be fine here no need to render an empty component, I am pretty sure Virtuoso is O(n) anyways.
No description provided.